Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

[MIT.xml] fix #14397 - #14417

Merged
jeremyn merged 3 commits into
EFForg:masterfrom
J0WI:14397
Jan 24, 2018
Merged

jeremyn merged 3 commits into
EFForg:masterfrom
J0WI:14397

Conversation

@J0WI

@J0WI J0WI commented Jan 24, 2018

Copy link
Copy Markdown
Contributor

No description provided.

@jeremyn

jeremyn commented Jan 24, 2018 •

Copy link
Copy Markdown
Contributor

MIT.xml:

(This is just one way to clean up the comments here, feel free to do something else.)

Nonfunctional hosts:

  • Remove web
  • Remove www
  • Remove ᵉ "client certificate was invalid or not provided"

Problematic hosts:

  • Add new category "client certificate was invalid or not provided"
  • Mark ^ with the new category
  • Add web with the new category
  • Mark www with the new category
  • Remove now-empty * Redirects to https://web

Also:

  • Remove the web target

MIT-complex.xml

  • Use /~puzzle instead of /~cpitcla/* for the three tests

@jeremyn jeremyn self-assigned this Jan 24, 2018
@jeremyn

jeremyn commented Jan 24, 2018

Copy link
Copy Markdown
Contributor

I guess you can just wrap the three tests in a comment, like this:

		<!-- should not get secured
		<test url="http://mit.edu/~puzzle/" />
		<test url="http://www.mit.edu/~puzzle/" />
		<test url="http://web.mit.edu/puzzle/www/" />
		-->

We don't really have anything like a "negative" test though.

@jeremyn

jeremyn commented Jan 24, 2018

Copy link
Copy Markdown
Contributor

7c10f9b is fine with me.

@J0WI

J0WI commented Jan 24, 2018

Copy link
Copy Markdown
Contributor Author

Sure, we fixed this in #14290...

@jeremyn
jeremyn merged commit ae374ad into EFForg:master Jan 24, 2018
@jeremyn jeremyn removed their assignment Jan 24, 2018
@J0WI
J0WI deleted the 14397 branch January 25, 2018 21:24
@varenc

varenc commented Jul 26, 2018 •

Copy link
Copy Markdown

@J0WI @jeremyn this update seems to introduce a new problem. Now http://web.mit.edu is rewritten to https://web.mit.edu which will fail for most people. (but confusingly not for MIT students/staff)

MIT has a rather unique situation where the HTTPS version of its main web domains (web.mit.edu, www.mit.edu) can only be accessed by MIT affiliates with an MIT issued client cert.

I think this rule should be deleted entirely because https on www.mit.edu and web.mit.edu is not working at all for the general public. If you're an MIT affiliate trying to debug this, be sure to delete your client certs before testing. (they're easy to get again at ca.mit.edu)

@J0WI

J0WI commented Aug 10, 2018

Copy link
Copy Markdown
Contributor Author

Thanks, I've filled #16236

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants